Re: [PATCH] i40e: improve message grepability
From: Ferruh Yigit <hidden>
Date: 2017-01-11 16:05:49
On 1/11/2017 9:49 AM, Michał Mirosław wrote:
Join message lines for easier grepping. PRIxXX are left glued to strings as they are in other parts of the file.
I can't apply this cleanly, would you mind rebasing on top of latest next-net? Also there is a minor nit below. Thanks, ferruh
quoted hunk ↗ jump to hunk
Signed-off-by: Michał Mirosław <redacted> --- drivers/net/i40e/i40e_ethdev.c | 308 +++++++++++++++++++++-------------------- 1 file changed, 160 insertions(+), 148 deletions(-)diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index db2aebdb..00c15f87 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c@@ -764,8 +764,8 @@ i40e_add_tx_flow_control_drop_filter(struct i40e_pf *pf) pf->main_vsi_seid, 0, TRUE, NULL, NULL); if (ret) - PMD_INIT_LOG(ERR, "Failed to add filter to drop flow control " - " frames from VSIs."); + PMD_INIT_LOG(ERR, + "Failed to add filter to drop flow control frames from VSIs.");
Most messages aligned to "(", but single tab can give more room for the
msg (4 more chars J), and tab is preferred one according DPDK coding
convention.
I don't have a strong opinion, what do you think?
<...>quoted hunk ↗ jump to hunk
@@ -1788,8 +1789,8 @@ i40e_dev_start(struct rte_eth_dev *dev) i40e_pf_enable_irq0(hw); if (dev->data->dev_conf.intr_conf.lsc != 0) - PMD_INIT_LOG(INFO, "lsc won't enable because of" - " no intr multiplex\n"); + PMD_INIT_LOG(INFO, + "lsc won't enable because of no intr multiplex\n");
Like this one is using tab. <...>