Thread (79 messages) 79 messages, 9 authors, 2017-05-05

Re: [PATCH] acl: remove invalid test

From: Ananyev, Konstantin <hidden>
Date: 2016-12-23 09:36:36

-----Original Message-----
From: Michal Miroslaw [mailto:mirq-linux@rere.qmqm.pl]
Sent: Friday, December 23, 2016 1:48 AM
To: Ananyev, Konstantin <redacted>
Cc: dev@dpdk.org
Subject: Re: [PATCH] acl: remove invalid test

On Mon, Dec 19, 2016 at 06:48:52PM +0000, Ananyev, Konstantin wrote:
quoted
Hi Michal,
quoted
-----Original Message-----
From: Michał Mirosław [mailto:mirq-linux@rere.qmqm.pl]
Sent: Wednesday, December 14, 2016 5:24 PM
To: dev@dpdk.org
Cc: Ananyev, Konstantin <redacted>
Subject: [PATCH] acl: remove invalid test

rte_acl_add_rules() has no way of checking rule size.

This was hidden because the test effectively checked that
adding a rule with userdata == 0 failed.
I suppose that changes have to be inside:
[PATCH v2] acl: allow zero verdict.
The 'allow zero verdict' patch depends on this one if we are to not have
a breaking tests inbetween. 
Exactly, that's why I think they either has to be in one series of patches,
with this one coming first and ' PATCH v2] acl: allow zero verdict' as the second one,
or just merge them into one.

Konstantin
Otherwise, it is an independent change.

I guess I can merge them, though, if you prefer it that way.

Best Regards,
Michał Mirosław
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help