Thread (79 messages) 79 messages, 9 authors, 2017-05-05

Re: [PATCH 13/13] i40e: improve message grepability

From: Ferruh Yigit <hidden>
Date: 2017-01-09 14:12:01

On 12/13/2016 1:08 AM, Michał Mirosław wrote:
Signed-off-by: Michał Mirosław <redacted>
---
<...>
 	if (ret)
-		PMD_INIT_LOG(ERR, "Failed to add filter to drop flow control "
-				  " frames from VSIs.");
+		PMD_INIT_LOG(ERR, "Failed to add filter to drop flow control frames from VSIs.");
According latest discussion, msg integrity has priority over line
limitation.

But can you please break the lines while keeping whole msg, like:
+		PMD_INIT_LOG(ERR,
			"Failed to add filter to drop flow control frames from VSIs.");

<...>
 	if (ret != I40E_SUCCESS) {
-		PMD_DRV_LOG(ERR, "Fail to debug read from "
-			    "I40E_GL_SWT_L2TAGCTRL[%d]", reg_id);
+		PMD_DRV_LOG(ERR, "Fail to debug read from I40E_GL_SWT_L2TAGCTRL[%d]", reg_id);
And can you wrap arguments into next line:
+		PMD_DRV_LOG(ERR,
			"Fail to debug read from I40E_GL_SWT_L2TAGCTRL[%d]",
			reg_id);

<...>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help