Hi,

-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Iremonger, Bernard
Sent: Tuesday, October 11, 2016 9:35 AM
To: Thomas Monjalon
Cc: Yigit, Ferruh; dev@dpdk.org; Shah, Rahul R; Lu, Wenzhuo;
az5157@att.com
Subject: Re: [dpdk-dev] [PATCH v7 2/2] app/test_pmd: add tests for new API's

Hi Thomas,

<snip>

quoted

quoted

quoted

Subject: Re: [dpdk-dev] [PATCH v7 2/2] app/test_pmd: add tests for
new API's

2016-10-11 16:09, Ferruh Yigit:

quoted

This will cause a compilation error for shared libraries. Because
PMDs not linked against application when compiled as shared
library but used as plugins.

Since it has been decided to have NIC specific APIs, we need to
re-work that approach to fix shared library compilation.

If testpmd uses the ixgbe API, it must be linked with the PMD.
Is there any issue adapting the testpmd makefile?
Hope that dlopen an already linked PMD is nicely managed.

The ixgbe API will  be used by other apps, for example Virtual
Function Daemon (VFD) Moving the following line in rte.app.mak solves
the problem

Line 117: _LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD)      += -

lrte_pmd_ixgbe

quoted

To Line 103.

Will this be acceptable?

I think we must not link PMD in the general case but let this responsibility to
the application in case it uses some specific functions.
Does it make sense?

Yes, ok, will just modify the testpmd makefile  for this case.

A couple of things:
You would need to use #ifdef RTE_LIBRTE_IXGBE_PMD in testpmd, right?
In case IXGBE is not available (maybe just modifying the makefile solves the problem).

Could you also add these new functions in the testpmd help?
Just add them in cmd_help_long_parsed.

Thanks,
Pablo

Regards,

Bernard.