Re: [PATCH v5 1/3] librte_ether: add API for VF management

Hi Thomas,

Subject: Re: [dpdk-dev] [PATCH v5 1/3] librte_ether: add API for VF
management

2016-09-29 15:16, Iremonger, Bernard:

quoted

quoted

2016-09-29 15:16, Bernard Iremonger:

quoted

+int
+rte_eth_dev_set_vf_vlan_stripq(uint8_t port, uint16_t vf, int
+on);

Why keeping this function in ethdev?

This function is using an existing API in the eth_dev_ops structure.

dev->dev_ops->vlan_strip_queue_set

The vlan_strip_queue_set API is used by  the i40e, ixgbe and mlx5 PMD's.

OK but it was not used to control VF from PF.
This line:
	(*dev->dev_ops->vlan_strip_queue_set)(dev, q + vf *
queues_per_pool, on); seems Intel specific.
Please keep "VF from PF" outside of ethdev for 16.11.

I will try calling  (*dev->dev_ops->vlan_strip_queue_set) from an ixgbe-specific function.
Will this be acceptable? 

Regards,

Bernard.