Hi Thomas,

<snip>

Subject: Re: [dpdk-dev] [PATCH v5 1/3] librte_ether: add API for VF
management

2016-09-29 15:16, Bernard Iremonger:

quoted

Add new API function to configure and manage VF's on a NIC.

add rte_eth_dev_set_vf_vlan_stripq function.

Signed-off-by: azelezniak <redacted>

We need the full name of azelezniak.

It is Alex Zelezniak, I will update the commit messages.

quoted

Signed-off-by: Bernard Iremonger <redacted>

[...]

quoted

+int
+rte_eth_dev_set_vf_vlan_stripq(uint8_t port, uint16_t vf, int on);

Why keeping this function in ethdev?

This function is using an existing API in the eth_dev_ops structure.

dev->dev_ops->vlan_strip_queue_set

The vlan_strip_queue_set API is used by  the i40e, ixgbe and mlx5 PMD's.

I think it would be more consistent to have also existing VF functions moving
from ethdev to rte_pmd_ixgbe.h.
You cannot remove them, but you can create their ixgbe-specific version and
announce that the ethdev ones are deprecated.

There are 5 existing VF functions which are only used by ixgbe PMD at present.
It would make sense to create ixgbe-specific versions, however I think this should be done in a separate patchset.

Regards,

Bernard