Thread (92 messages) 92 messages, 9 authors, 2016-03-09

Re: [PATCH v4 2/4] eal: set kdrv to RTE_KDRV_NONE if kernel driver isn't managing the device

From: Xie, Huawei <hidden>
Date: 2016-02-29 09:01:49

On 2/29/2016 4:47 PM, David Marchand wrote:
On Fri, Feb 26, 2016 at 2:53 AM, Huawei Xie [off-list ref] wrote:
quoted
v4 changes:
 reword the commit message. When we mention kernel driver, emphasizes
that it includes UIO/VFIO.
Annotations should not be part of the commitlog itself.
Do you mean that "rewording the commit message" should not appear in the
commit message itself?  Those version changes will not appear in the
commit log when applied, right? So i added this so that reviewers know
that i have changed the commit message otherwise they don't need to
waste their time reviewing the commit message again. Is it that even if
i send a new patch version with only the changes to the commit message ,
i needn't mention this?
quoted
Use RTE_KDRV_NONE to indicate that kernel driver(including UIO/VFIO)
isn't manipulating the device.
missing space before (
Thomas, could you help change this?
quoted
Signed-off-by: Huawei Xie <redacted>
Acked-by: Yuanhan Liu <redacted>
Thought I already acked this.
Anyway,
Acked-by: David Marchand <redacted>
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help