Thread (92 messages) 92 messages, 9 authors, 2016-03-09

Re: [PATCH v2 4/4] virtio: check if any kernel driver is manipulating the virtio device

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2016-01-04 17:24:03

On Mon,  4 Jan 2016 01:56:13 +0800
Huawei Xie [off-list ref] wrote:
+	if (pci_dev->kdrv != RTE_KDRV_NONE) {
+		PMD_INIT_LOG(INFO,
+			"kernel driver is manipulating this device." \
+			" Please unbind the kernel driver.");
Splitting strings in general is a bad idea since it makes it harder to find log messages.
Also the first clause is lower case and the second is captialized.

Lastly, the backslash continuation is unnecessary here and will cause checkpatch warning.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help