On Mon, Jan 04, 2016 at 05:56:49PM +0000, Xie, Huawei wrote:

On 1/5/2016 1:24 AM, Stephen Hemminger wrote:

quoted

On Mon,  4 Jan 2016 01:56:13 +0800
Huawei Xie [off-list ref] wrote:

quoted

+	if (pci_dev->kdrv != RTE_KDRV_NONE) {
+		PMD_INIT_LOG(INFO,
+			"kernel driver is manipulating this device." \
+			" Please unbind the kernel driver.");

Splitting strings in general is a bad idea since it makes it harder to find log messages.
Also the first clause is lower case and the second is captialized.

Got it. This is to avoid 80 char warning. Will put it in one line to
make it friendly for searching.

I agree with Stephen that _in general_ it's a bad idea. But for this
case, I think it's okay, as it'd be enough to locate the code by
searching "manipulating this device", or "unbind the kernel driver",
or other combinations. I mean, nobody would try searching with:

  "kernel driver is manipulating this device. Please unbind the kernel driver."

Right?

	--yliu

The first clause is lower is because it actually follows "%s():".

quoted

Lastly, the backslash continuation is unnecessary here and will cause checkpatch warning.