On Mon, Jan 04, 2016 at 05:56:49PM +0000, Xie, Huawei wrote:

On 1/5/2016 1:24 AM, Stephen Hemminger wrote:

quoted

On Mon,  4 Jan 2016 01:56:13 +0800
Huawei Xie [off-list ref] wrote:

quoted

+	if (pci_dev->kdrv != RTE_KDRV_NONE) {
+		PMD_INIT_LOG(INFO,
+			"kernel driver is manipulating this device." \
+			" Please unbind the kernel driver.");

Splitting strings in general is a bad idea since it makes it harder to find log messages.
Also the first clause is lower case and the second is captialized.

Got it. This is to avoid 80 char warning. Will put it in one line to
make it friendly for searching.
The first clause is lower is because it actually follows "%s():".

Indeed checkpatch lets logging functions be longer than 80 chars, so does not forces to split message.
But checkpatch detects kernel logging functions only, not ours, that is why we are still getting over 80 chars warning.

Should we ignore LONG_LINE_STRING warnings in checkpatch?

Thanks,
ferruh