Thread (71 messages) 71 messages, 7 authors, 2012-06-13

Re: [PATCH -V8 10/16] hugetlb/cgroup: Add the cgroup pointer to page lru

From: Aneesh Kumar K.V <hidden>
Date: 2012-06-09 17:04:41
Also in: linux-mm, lkml

"Aneesh Kumar K.V" [off-list ref] writes:
quoted hunk ↗ jump to hunk
From: "Aneesh Kumar K.V" <redacted>

Add the hugetlb cgroup pointer to 3rd page lru.next. This limit
the usage to hugetlb cgroup to only hugepages with 3 or more
normal pages. I guess that is an acceptable limitation.

Signed-off-by: Aneesh Kumar K.V <redacted>
---
 include/linux/hugetlb_cgroup.h |   31 +++++++++++++++++++++++++++++++
 mm/hugetlb.c                   |    4 ++++
 2 files changed, 35 insertions(+)
diff --git a/include/linux/hugetlb_cgroup.h b/include/linux/hugetlb_cgroup.h
index 5794be4..ceff1d5 100644
--- a/include/linux/hugetlb_cgroup.h
+++ b/include/linux/hugetlb_cgroup.h
@@ -26,6 +26,26 @@ struct hugetlb_cgroup {
 };

 #ifdef CONFIG_CGROUP_HUGETLB_RES_CTLR
+static inline struct hugetlb_cgroup *hugetlb_cgroup_from_page(struct page *page)
+{
+	if (!PageHuge(page))
+		return NULL;
+	if (compound_order(page) < 3)
That should be if (compound_order(page) < 2) ? I will send an updated
patchset with this fix and other review changes.


-aneesh 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help