Re: [PATCH -V8 14/16] hugetlb/cgroup: add charge/uncharge calls for HugeTLB alloc/free
From: Johannes Weiner <hannes@cmpxchg.org>
Date: 2012-06-09 09:23:17
Also in:
linux-mm, lkml
From: Johannes Weiner <hannes@cmpxchg.org>
Date: 2012-06-09 09:23:17
Also in:
linux-mm, lkml
On Sat, Jun 09, 2012 at 02:29:59PM +0530, Aneesh Kumar K.V wrote:
From: "Aneesh Kumar K.V" <redacted> This adds necessary charge/uncharge calls in the HugeTLB code. We do hugetlb cgroup charge in page alloc and uncharge in compound page destructor. Signed-off-by: Aneesh Kumar K.V <redacted> --- mm/hugetlb.c | 16 +++++++++++++++- mm/hugetlb_cgroup.c | 7 +------ 2 files changed, 16 insertions(+), 7 deletions(-)diff --git a/mm/hugetlb.c b/mm/hugetlb.c index bf79131..4ca92a9 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c@@ -628,6 +628,8 @@ static void free_huge_page(struct page *page) BUG_ON(page_mapcount(page)); spin_lock(&hugetlb_lock); + hugetlb_cgroup_uncharge_page(hstate_index(h), + pages_per_huge_page(h), page);
hugetlb_cgroup_uncharge_page() takes the hugetlb_lock, no? It's quite hard to review code that is split up like this. Please always keep the introduction of new functions in the same patch that adds the callsite(s). -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>