Re: [PATCH -V8 02/16] hugetlb: don't use ERR_PTR with VM_FAULT* values
From: Aneesh Kumar K.V <hidden>
Date: 2012-06-09 13:17:28
Also in:
linux-mm, lkml
From: Aneesh Kumar K.V <hidden>
Date: 2012-06-09 13:17:28
Also in:
linux-mm, lkml
Konrad Rzeszutek Wilk [off-list ref] writes:
On Sat, Jun 09, 2012 at 02:29:47PM +0530, Aneesh Kumar K.V wrote:quoted
From: "Aneesh Kumar K.V" <redacted> The current use of VM_FAULT_* codes with ERR_PTR requires us to ensure VM_FAULT_* values will not exceed MAX_ERRNO value. Decouple the VM_FAULT_* values from MAX_ERRNO.I see you using the -ENOMEM|-ENOSPC, but I don't see any reference in the code to MAX_ERRNO? Can you provide a comment explaining in a tad little bit about the interaction of MAX_ERRNO and VM_FAULT?
That comes from this #define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO) -aneesh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>