On Mon, 3 Jun 2019 18:03:37 +0200
Cornelia Huck [off-list ref] wrote:

On Wed, 29 May 2019 14:26:57 +0200
Michael Mueller [off-list ref] wrote:

quoted

From: Halil Pasic <pasic@linux.ibm.com>

Hypervisor needs to interact with the summary indicators, so these
need to be DMA memory as well (at least for protected virtualization
guests).

Signed-off-by: Halil Pasic <pasic@linux.ibm.com>
Signed-off-by: Michael Mueller <redacted>
---
 drivers/s390/virtio/virtio_ccw.c | 26 +++++++++++++++++++-------
 1 file changed, 19 insertions(+), 7 deletions(-)

(...)

quoted

@@ -1501,6 +1508,11 @@ static int __init virtio_ccw_init(void)
 {
 	/* parse no_auto string before we do anything further */
 	no_auto_parse();
+
+	summary_indicators = cio_dma_zalloc(MAX_AIRQ_AREAS);
+	if (!summary_indicators)
+		return -ENOMEM;
+
 	return ccw_driver_register(&virtio_ccw_driver);

Don't you need to free summary_indicators again if registering the
driver fails?

We do! BTW as of today I'm back and I intend to handle things
regularly form now on ;).

Regards,
Halil

quoted

 }
 device_initcall(virtio_ccw_init);