On Mon, 3 Jun 2019 14:09:02 +0200
Michael Mueller [off-list ref] wrote:

quoted

quoted

@@ -1059,16 +1168,19 @@ static int __init css_bus_init(void)
  	if (ret)
  		goto out_unregister;
  	ret = register_pm_notifier(&css_power_notifier);
-	if (ret) {
-		unregister_reboot_notifier(&css_reboot_notifier);
-		goto out_unregister;
-	}
+	if (ret)
+		goto out_unregister_rn;
+	ret = cio_dma_pool_init();
+	if (ret)
+		goto out_unregister_rn;  

Don't you also need to unregister the pm notifier on failure here?  

Mmh, that was the original intention. Thanks!

I suppose we could also move cio_dma_pool_init() right before the
register_reboot_notifier() call and goto out_unregister on error.

Regards,
Halil