Re: [PATCH 05/20] Staging: hv: util: Perform some service specific init/deinit in probe/remove
From: Greg KH <hidden>
Date: 2011-09-16 18:08:44
Also in:
lkml
On Tue, Sep 13, 2011 at 10:59:41AM -0700, K. Y. Srinivasan wrote:
quoted hunk ↗ jump to hunk
--- a/drivers/staging/hv/hv_util.c +++ b/drivers/staging/hv/hv_util.c@@ -30,9 +30,31 @@ #include "hyperv.h" #include "hv_kvp.h" -static u8 *shut_txf_buf; -static u8 *time_txf_buf; -static u8 *hbeat_txf_buf; + +static void shutdown_onchannelcallback(void *context); +static struct hv_util_service util_shutdown = { + .service_name = "Shutdown channel functionality initialized\n",
That's not a name, it's a text string to send to userspace, and it's really redundant given the other times you use this. Please just put the name here, if you really need it (hint, you really don't, so just drop it please.) greg k-h