RE: [PATCH 06/20] Staging: hv: util: Properly handle util services in the util driver

-----Original Message-----
From: Dan Carpenter [mailto:error27@gmail.com]
Sent: Thursday, September 15, 2011 4:09 PM
To: KY Srinivasan
Cc: gregkh@suse.de; linux-kernel@vger.kernel.org;
devel@linuxdriverproject.org; virtualization@lists.osdl.org; Haiyang Zhang
Subject: Re: [PATCH 06/20] Staging: hv: util: Properly handle util services in the
util driver

On Tue, Sep 13, 2011 at 10:59:42AM -0700, K. Y. Srinivasan wrote:

quoted

@@ -403,31 +384,13 @@ static void vmbus_process_offer(struct work_struct

*work)

quoted

 		spin_unlock_irqrestore(&vmbus_connection.channel_lock,

flags);

quoted

 		free_channel(newchannel);
-	} else {
+	} else
 		/*
 		 * This state is used to indicate a successful open
 		 * so that when we do close the channel normally, we
 		 * can cleanup properly
 		 */
 		newchannel->state = CHANNEL_OPEN_STATE;

It's not worth resending, but this should have kept the curly braces
for two style reasons.
1) If one side of the if else pair has braces the other side gets
braces too.
2) If it's more than one line, it gets braces even if it's not needed
for semantic reasons.

Sorry to email you these pedantic things, but if I don't then my OCD
acts up and I feel all itchy for hours.  Also you have a similar
thing below as well.

Thanks Dan. I will wait for Greg's action here. Given that Kernel.org is still
down, we are all kind of flying in the dark here.

Regards,

K. Y