Re: [PATCH 20/20] Staging: hv: netvsc: Rename deviceInfo as device_info

[PATCH 0000/0020] Staging: hv: Driver cleanup · "K. Y. Srinivasan" <kys@microsoft.com> · 2011-09-13
[PATCH 01/20] Staging: hv: vmbus: Introduce a utility function to match hv_vmbus_device_id · "K. Y. Srinivasan" <kys@microsoft.com> · 2011-09-13
[PATCH 03/20] Staging: hv: storvsc: Use the driver_data to identify ide · "K. Y. Srinivasan" <kys@microsoft.com> · 2011-09-13
[PATCH 20/20] Staging: hv: netvsc: Rename deviceInfo as device_info · "K. Y. Srinivasan" <kys@microsoft.com> · 2011-09-13
Re: [PATCH 20/20] Staging: hv: netvsc: Rename deviceInfo as device_info · Joe Perches <joe@perches.com> · 2011-09-13
RE: [PATCH 20/20] Staging: hv: netvsc: Rename deviceInfo as device_info · KY Srinivasan <kys@microsoft.com> · 2011-09-13
[PATCH 18/20] Staging: hv: netvsc: Rename netDevice as net_device · "K. Y. Srinivasan" <kys@microsoft.com> · 2011-09-13
[PATCH 13/20] Staging: hv: netvsc: Get rid of the usage of the ext field in struct hv_device · "K. Y. Srinivasan" <kys@microsoft.com> · 2011-09-13
[PATCH 17/20] Staging: hv: vmbus: Get rid of the module dependency · "K. Y. Srinivasan" <kys@microsoft.com> · 2011-09-13
[PATCH 16/20] Staging: hv: vmbus: Do not allocate struct hv_device_info on the stack · "K. Y. Srinivasan" <kys@microsoft.com> · 2011-09-13
Re: [PATCH 16/20] Staging: hv: vmbus: Do not allocate struct hv_device_info on the stack · Christoph Hellwig <hch@infradead.org> · 2011-09-13
[PATCH 08/20] Staging: hv: vmbus: Cleanup vmbus_remove() · "K. Y. Srinivasan" <kys@microsoft.com> · 2011-09-13
[PATCH 12/20] Staging: hv: storvsc: Eliminate the usage of ext field in struct hv_device · "K. Y. Srinivasan" <kys@microsoft.com> · 2011-09-13
[PATCH 09/20] Staging: hv: storvsc: Get rid of storvsc_dev_add() by inlining the code · "K. Y. Srinivasan" <kys@microsoft.com> · 2011-09-13
Re: [PATCH 09/20] Staging: hv: storvsc: Get rid of storvsc_dev_add() by inlining the code · Christoph Hellwig <hch@infradead.org> · 2011-09-13
RE: [PATCH 09/20] Staging: hv: storvsc: Get rid of storvsc_dev_add() by inlining the code · KY Srinivasan <kys@microsoft.com> · 2011-09-13
[PATCH 06/20] Staging: hv: util: Properly handle util services in the util driver · "K. Y. Srinivasan" <kys@microsoft.com> · 2011-09-13
Re: [PATCH 06/20] Staging: hv: util: Properly handle util services in the util driver · Dan Carpenter <hidden> · 2011-09-15
RE: [PATCH 06/20] Staging: hv: util: Properly handle util services in the util driver · KY Srinivasan <kys@microsoft.com> · 2011-09-15
Re: [PATCH 06/20] Staging: hv: util: Properly handle util services in the util driver · Greg KH <hidden> · 2011-09-16
RE: [PATCH 06/20] Staging: hv: util: Properly handle util services in the util driver · KY Srinivasan <kys@microsoft.com> · 2011-09-17
[PATCH 02/20] Staging: hv: vmbus: Change the signature of struct hv_driver probe function · "K. Y. Srinivasan" <kys@microsoft.com> · 2011-09-13
[PATCH 10/20] Staging: hv: storvsc: Get rid of alloc_stor_device() by inlining the code · "K. Y. Srinivasan" <kys@microsoft.com> · 2011-09-13
[PATCH 11/20] Staging: hv: storvsc: Get rid of some unnecessary state and definitions · "K. Y. Srinivasan" <kys@microsoft.com> · 2011-09-13
[PATCH 19/20] Staging: hv: netvsc: Rename rndisDevice to rndis_device · "K. Y. Srinivasan" <kys@microsoft.com> · 2011-09-13
[PATCH 05/20] Staging: hv: util: Perform some service specific init/deinit in probe/remove · "K. Y. Srinivasan" <kys@microsoft.com> · 2011-09-13
Re: [PATCH 05/20] Staging: hv: util: Perform some service specific init/deinit in probe/remove · Greg KH <hidden> · 2011-09-16
[PATCH 04/20] Staging: hv: vmbus: Introduce functions for setting and getting driver data · "K. Y. Srinivasan" <kys@microsoft.com> · 2011-09-13
[PATCH 07/20] Staging: hv: vmbus: Get rid of hv_cb_utils[] and other unneeded code · "K. Y. Srinivasan" <kys@microsoft.com> · 2011-09-13
[PATCH 15/20] Staging: hv: vmbus: Get rid of the ext field in struct hv_device · "K. Y. Srinivasan" <kys@microsoft.com> · 2011-09-13
[PATCH 14/20] Staging: hv: mousevsc: Get rid of the usage of the ext field in struct hv_device · "K. Y. Srinivasan" <kys@microsoft.com> · 2011-09-13
Re: [PATCH 0000/0020] Staging: hv: Driver cleanup · Greg KH <hidden> · 2011-09-16
RE: [PATCH 0000/0020] Staging: hv: Driver cleanup · KY Srinivasan <kys@microsoft.com> · 2011-09-17

From: Joe Perches <joe@perches.com>
Date: 2011-09-13 18:10:33
Also in: lkml

On Tue, 2011-09-13 at 10:59 -0700, K. Y. Srinivasan wrote:

Rename deviceInfo as device_info.

[]

quoted hunk ↗ jump to hunk

diff --git a/drivers/staging/hv/rndis_filter.c b/drivers/staging/hv/rndis_filter.c

[]

quoted hunk ↗ jump to hunk

@@ -732,15 +732,15 @@ int rndis_filter_device_add(struct hv_device *dev,

[]

 	dev_info(&dev->device, "Device MAC %pM link state %s",
 		 rndis_device->hw_mac_adr,
-		 ((deviceInfo->link_state) ? ("down\n") : ("up\n")));
+		 ((device_info->link_state) ? ("down\n") : ("up\n")));

Maybe get rid of the superfluous parentheses too?

	dev_info(&dev->device, "Device MAC %pM link state %s\n",
		 rndis_device->hw_mac_adr,
		 device_info->link_state ? "down" : "up");

Also, struct rndis_device uses
	u32 link_stat;
that is copied into struct netvsc_device_info
	bool link_state;
could you please rationalize the names and types
of those 2 variables?

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help