RE: [PATCH 10/25] Staging: hv: vmbus: Return proper error code in vmbus_remove()
From: KY Srinivasan <kys@microsoft.com>
Date: 2011-09-10 14:22:24
Also in:
lkml
-----Original Message----- From: Greg KH [mailto:greg@kroah.com] Sent: Friday, September 09, 2011 4:43 PM To: KY Srinivasan Cc: gregkh@suse.de; linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; virtualization@lists.osdl.org; Haiyang Zhang Subject: Re: [PATCH 10/25] Staging: hv: vmbus: Return proper error code in vmbus_remove() On Thu, Sep 08, 2011 at 07:24:21AM -0700, K. Y. Srinivasan wrote:quoted
Return proper error code in vmbus_remove(). Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> --- drivers/staging/hv/vmbus_drv.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c index b9aeb76..95d33a4 100644 --- a/drivers/staging/hv/vmbus_drv.c +++ b/drivers/staging/hv/vmbus_drv.c@@ -325,7 +325,7 @@ static int vmbus_probe(struct device *child_device) */ static int vmbus_remove(struct device *child_device) { - int ret; + int ret = 0;As remove functions can't fail, why return anything at all? Doesn't make sense, please fix.
Greg, Looking at the struct bus_type, the remove function is not a void function. I was just fixing something that was broken in this function. Regards, K. Y