Re: [PATCH 06/25] Staging: hv: storvsc: Use the driver_data to identify ide
From: Greg KH <hidden>
Date: 2011-09-09 20:47:34
Also in:
lkml
On Thu, Sep 08, 2011 at 07:24:17AM -0700, K. Y. Srinivasan wrote:
quoted hunk ↗ jump to hunk
Use the driver_data to identify ide devices in storvsc_probe(). Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> --- drivers/staging/hv/storvsc_drv.c | 13 +++++-------- 1 files changed, 5 insertions(+), 8 deletions(-)diff --git a/drivers/staging/hv/storvsc_drv.c b/drivers/staging/hv/storvsc_drv.c index fff1e5b..e2c63e5 100644 --- a/drivers/staging/hv/storvsc_drv.c +++ b/drivers/staging/hv/storvsc_drv.c@@ -1366,10 +1366,12 @@ static struct scsi_host_template scsi_driver = { static const struct hv_vmbus_device_id id_table[] = { /* SCSI guid */ { VMBUS_DEVICE(0xd9, 0x63, 0x61, 0xba, 0xa1, 0x04, 0x29, 0x4d, - 0xb6, 0x05, 0x72, 0xe2, 0xff, 0xb1, 0xdc, 0x7f) }, + 0xb6, 0x05, 0x72, 0xe2, 0xff, 0xb1, 0xdc, 0x7f) + .driver_data = 0 },
What does 0 mean? That's the "default" here, right?
/* IDE guid */
{ VMBUS_DEVICE(0x32, 0x26, 0x41, 0x32, 0xcb, 0x86, 0xa2, 0x44,
- 0x9b, 0x5c, 0x50, 0xd1, 0x41, 0x73, 0x54, 0xf5) },
+ 0x9b, 0x5c, 0x50, 0xd1, 0x41, 0x73, 0x54, 0xf5)
+ .driver_data = 1 },What does 1 mean? And yes, I can guess, but please, will you really remember this in 2 years? enums are your friend... PLEASE make your code easier to maintain for the person who has to come clean it up after you, which is usually yourself so you are only making your own life easier. greg k-h