Thread (18 messages) 18 messages, 8 authors, 2007-03-09

Re: hardwired VMI crap

From: Zachary Amsden <hidden>
Date: 2007-03-08 23:55:08
Also in: lkml

Jeremy Fitzhardinge wrote:
No, but I'm not prejudiced against virtual hardware.  If we have a piece
of code that thinks its talking to an apic, then I think its OK to use
that code whether its a real apic or a virtual one, _so long as its
being used in a way that's consistent with its intended interface_.  I
have to admit I have not looked at apics - real or virtual - in any
detail, so I won't claim to really understand the details of the
existing arch/i386 code or what VMI's trying to do, but it does seem to
me that it could all be much cleaner.

And clean is good, we all love clean - and so, agreement!
  
For APICs, we have two operations - APICRead and APICWrite.  It is nice 
and clean, and plugs in very easily to the APIC accessors available in 
Linux.

Is this not clean?

We just don't drive the local timer interrupts through the APIC, we make 
hypercalls to schedule local timer alarms.  Which is something we must 
do for UP kernels as well, which use the PIT / PIC.  So there is a need 
for having clockevents code which doesn't program timers through the APIC.

So we have one separate time device, independent from the traditional 
hardware timers, and we just program that.  This design is not very 
complex, nor is it unclean, IMHO.

Zach
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help