Thread (31 messages) 31 messages, 7 authors, 2006-08-08

Re: [PATCH 1/4] x86 paravirt_ops: create no_paravirt.h for native ops

From: Rusty Russell <hidden>
Date: 2006-08-07 06:03:40
Also in: lkml

On Sun, 2006-08-06 at 22:43 -0700, Jeremy Fitzhardinge wrote:
Andi Kleen wrote:
quoted
quoted
+/* Stop speculative execution */
+static inline void sync_core(void)
+{
+	unsigned int eax = 1, ebx, ecx, edx;
+	__cpuid(&eax, &ebx, &ecx, &edx);
+}
    
Actually I don't think this one should be para virtualized at all.
I don't see any reason at all why a hypervisor should trap it and it
is very time critical. I would recommend you move it back into the 
normal files without hooks.
I don't see where it's time-critical...

Rusty.
-- 
Help! Save Australia from the worst of the DMCA: http://linux.org.au/law
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help