Thread (92 messages) 92 messages, 4 authors, 2012-06-17

[ 44/82] ext4: add ext4_mb_unload_buddy in the error path

From: Ben Hutchings <hidden>
Date: 2012-06-08 05:25:36
Also in: lkml

3.2-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Salman Qazi <redacted>

commit 02b7831019ea4e7994968c84b5826fa8b248ffc8 upstream.

ext4_free_blocks fails to pair an ext4_mb_load_buddy with a matching
ext4_mb_unload_buddy when it fails a memory allocation.

Signed-off-by: Salman Qazi <redacted>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Ben Hutchings <redacted>
---
 fs/ext4/mballoc.c |    1 +
 1 file changed, 1 insertion(+)
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -4693,6 +4693,7 @@
 		 */
 		new_entry = kmem_cache_alloc(ext4_free_ext_cachep, GFP_NOFS);
 		if (!new_entry) {
+			ext4_mb_unload_buddy(&e4b);
 			err = -ENOMEM;
 			goto error_return;
 		}

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help