Re: [PATCH net-next v16 5/7] net: stmmac: qcom-ethqos: reuse the address of ethqos_emac_driver_data
flat view
From: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
Date: 2026-10-17 16:42:50
Also in:
imx, linux-amlogic, linux-arm-kernel, linux-arm-msm, linux-devicetree, linux-mips, linux-renesas-soc, linux-riscv, linux-rockchip, linux-sunxi, lkml
On Wed, Oct 14, 2026 at 02:36:44PM +0200, Bartosz Golaszewski wrote:
Instead of needlessly copying the fields of ethqos_emac_driver_data into struct qcom_ethqos, just use the address of the former as a reference. It's .rodata after all. This is done in order to avoid having either two calls to of_device_get_match_data() or having to extend the latter with another field when adding support for SCMI. Signed-off-by: Bartosz Golaszewski <redacted> ---
After testing it on a couple of legacy non-SCMI boards, I did not find any issues with this patch, so: Tested-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com> Reviewed-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com> Ayaan