Re: [PATCH net-next v18 3/3] net: phy: Add driver for Motorcomm Quad 2.5GbE phy

On 9/15/26 20:31, Andrew Lunn wrote:

quoted

+ * yt8824_utp_invalid_test_mode_paged() - config YT8824 to invalid test mode.
+ * @phydev: a pointer to a &struct phy_device
+ *
+ * Returns: 0 or negative errno code
+ */
+static int yt8824_utp_invalid_test_mode_paged(struct phy_device *phydev)
+{
+	int ret;
+
+	ret = phy8824_page_write_with_lock(phydev, YT8824_RSSR_UTP_SPACE);
+	if (ret < 0)
+		return ret;
+
+	return genphy_c45_template_testmode
+		(phydev, MDIO_PMA_10GBT_TESTMODE_1);

MDIO_PMA_10GBT_TESTMODE_1 is defined by 802.3. How can it be invalid?

Is the description wrong, and this hardware does not support test mode
1?

Ans: What's expressed here is switching to a test mode — other modes

         would work too. Here it defaults to switching to testmode1. 
Later on,

          I'm considering either renaming the function or just renaming 
directly

        to testmode1.

	Andrew