Re: [PATCH net-next v18 3/3] net: phy: Add driver for Motorcomm Quad 2.5GbE phy

On 9/15/26 20:33, Andrew Lunn wrote:

quoted

+	res = of_get_phy_mode(np, &priv->interface_mode);
+	if (res < 0) {
+		phydev_warn(phydev, "%s, phy-mode missing in DTS.\n", __func__);
+		priv->interface_mode = PHY_INTERFACE_MODE_INTERNAL;

In the binding you say phy-mode is a required property. So if it is
missing, it should be a fatal error.

Ans: I had considered this issue before submitting the patch.

         Between using a default value and returning an exception,

         the code currently chooses to provide a default. This will be

         changed to return an fatal error in a later version.

	 Andrew