Thread (15 messages) flat view 15 messages, 4 authors, 10d ago

Re: [PATCH net] net: amd-xgbe: support receiving packets with bad FCS

From: Simon Horman <horms@kernel.org>
Date: 2026-08-19 09:01:56

On Wed, Aug 19, 2026 at 12:36:01PM +1000, James wrote:
On Fri, Aug 14, 2026 at 11:09:16AM +0100, Simon Horman [off-list ref] wrote:
quoted
FWIW, I lean towards this being an enhancement for net-next without
a Fixes tag. Rather than a fix.
Hi Simon, thank you for the review! Apologise for the late reply as I was
unwell last week.

My rationale for targeting `net` was that the driver currently accepts bad
FCS frames by default, which I believe should be an incorrect existing behavior.
The `NETIF_F_RXALL` I added is intended to preserve access to that behavior
only when a user explicitly requests it.

With that said, I understand that exposing the `rx-all` control may make
this better suited for `net-next`. Do you prefer that I respin this as a
`net-next` patch (when it opens later this month), or do you think the
default-behavior correction justifies keeping it in `net`?
I do lean towards this being for net-next. But if you feel strongly
that it is for net, I won't push the matter any further.

BTW, net-next is currently closed. So if you do post it for net-next you
will need to wait for it to reopen around 31st August.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help