Thread (15 messages) flat view 15 messages, 4 authors, 9d ago

Re: [PATCH net] net: amd-xgbe: support receiving packets with bad FCS

From: James <hidden>
Date: 2026-08-19 02:36:29

On Fri, Aug 14, 2026 at 11:09:16AM +0100, Simon Horman [off-list ref] wrote:
FWIW, I lean towards this being an enhancement for net-next without
a Fixes tag. Rather than a fix.
Hi Simon, thank you for the review! Apologise for the late reply as I was
unwell last week.

My rationale for targeting `net` was that the driver currently accepts bad
FCS frames by default, which I believe should be an incorrect existing behavior.
The `NETIF_F_RXALL` I added is intended to preserve access to that behavior
only when a user explicitly requests it.

With that said, I understand that exposing the `rx-all` control may make
this better suited for `net-next`. Do you prefer that I respin this as a
`net-next` patch (when it opens later this month), or do you think the
default-behavior correction justifies keeping it in `net`?

Regards,
James
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help