Thread (34 messages) flat view 34 messages, 5 authors, 5d ago

Re: [PATCH v2 06/10] net: pcs: xpcs: add ANRESTART support for SGMII link recovery

From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-08-01 21:11:03
Also in: linux-arm-kernel, linux-devicetree, linux-phy, linux-renesas-soc, linux-rockchip, lkml

-	/* Clear AN complete status or interrupt */
-	if (state->an_complete)
+	if (state->an_complete) {
+		/* Clear AN complete status or interrupt */
 		xpcs_write(xpcs, MDIO_MMD_VEND2, DW_VR_MII_AN_INTR_STS, 0);
 
+		/* Initiate the next round of AN */
+		xpcs_modify(xpcs, MDIO_MMD_VEND2, MII_BMCR, BMCR_ANRESTART,
+				    BMCR_ANRESTART);
+	}
+
This probably needs more wide spread testing. I would be afraid that
if you kick off an AN cycle, you loose the link until it completes?
You would of noticed that on your hardware, but other hardware
obviously behaves differently...

   Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help