quoted

quoted

+     if (tp->sfp_mode) {
+             phy_mode = PHY_INTERFACE_MODE_INTERNAL;
+             tp->phylink_config.mac_capabilities |= MAC_10000FD;

Only 10G? Is it not possible to slow down to 1G for a 1G SFP?

It can support 1G SFP as well.

I only added MAC_10000FD here because the original code path only added
the 10G capability, and I was trying to keep the behavior unchanged in
this conversion patch.

That is a good reason to keep it the same. But since the hardware can
do 1G, please add a follow up patch adding 1G support.

   Andrew