Re: [PATCH net-next v2 08/11] net: sched: don't recurse on the netdev ops lock in qdiscs
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Date: 2026-06-04 23:38:22
Also in:
linux-leds
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Date: 2026-06-04 23:38:22
Also in:
linux-leds
Jakub Kicinski [off-list ref] writes:
cbs_set_port_rate() and taprio_set_picos_per_byte() are reached from
two paths and both already hold the device's ops lock:
*_change(), via tc_modify_qdisc() which calls netdev_lock_ops(dev)
before dispatching to the qdisc ops.
*_dev_notifier() on NETDEV_UP / NETDEV_CHANGE, where caller
holds the ops lock across the notifier chain.
Switch to netif_get_link_ksettings() to avoid deadlock once
__ethtool_get_link_ksettings() starts taking the netdev lock.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> Cheers, -- Vinicius