Thread (28 messages) 28 messages, 9 authors, 2026-06-04

Re: [PATCH net-next v2 01/11] net: rename netdev_ops_assert_locked()

From: Jakub Sitnicki <jakub@cloudflare.com>
Date: 2026-06-03 11:15:11
Also in: linux-leds

On Tue, Jun 02, 2026 at 06:28 PM -07, Jakub Kicinski wrote:
Jakub suggests renaming the existing assert to match
the netdev_lock_ops_compat() semantics.

We want netdev_assert_locked_ops() to mean - if the driver
is ops locked - check that it's holding the device lock.

The existing helper check for either ops lock or rtnl_lock,
which is the locking behavior of netdev_lock_ops_compat().

The reason for naming divergence is likely that
netdev_ops_assert_locked() predated the _compat() helpers.

Suggested-by: Jakub Sitnicki <jakub@cloudflare.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
v2:
 - new patch
---
Reviewed-by: Jakub Sitnicki <jakub@cloudflare.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help