Re: [PATCH net-next v3 1/3] dt-bindings: ethernet: eswin: add clock sampling control

On Tue, Mar 03, 2026 at 05:23:18PM -0800, Bo Gan wrote:

Hi All,

On 3/3/26 16:47, Conor Dooley wrote:

quoted

On Tue, Mar 03, 2026 at 04:38:46PM -0800, Jakub Kicinski wrote:

quoted

On Tue,  3 Mar 2026 14:16:37 +0800 lizhi2@eswincomputing.com wrote:

quoted

There are currently no in-tree users of the EIC7700 Ethernet driver, so
these changes are safe.

What do you mean by this sentence? The commit under Fixes was part of
Linux v6.19 already.

The "funny" thing is that caring about users doesn't even really matter
on the devicetree patch, except for this hunk:
|@@ -81,7 +99,9 @@ properties:
|                          or external clock selection
|           - description: Offset of AXI clock controller Low-Power request
|                          register
|+          - description: Offset of register controlling TXD delay
|           - description: Offset of register controlling TX/RX clock delay
|+          - description: Offset of register controlling RXD delay
|
| required:
|   - compatible
And it only matters here because an item is injected mid-list. If this
was moved to the end with the RXD delay, the **dt-binding** changes
don't have issues with safety. I've not looked at whether there are
knock-on concerns about users in the driver or whatever yet, but from a
binding POV only that hunk can break something that currently works.

This was already discussed here in v1:
https://lore.kernel.org/lkml/e7183ae1-8b8b-4e77-9f4e-3bc1b4b63556@lunn.ch/ (local)

The device-tree is not checked in yet by ESWIN folks, so there's currently
no user of the dt-binding. No need to worry about backward compat.

Of course there is user of this binding, for example ESWIN. Or many
other vendors using it out of tree. You documented ABI.

Best regards,
Krzysztof