Re: [PATCH] [net-next] net/mlx5e: fix ip6_dst_lookup link failure
From: Jianbo Liu <hidden>
Date: 2026-02-06 11:45:33
Also in:
linux-rdma, lkml
On 2/6/2026 6:00 PM, Arnd Bergmann wrote:
On Fri, Feb 6, 2026, at 10:56, Jianbo Liu wrote:quoted
On 2/4/2026 9:00 PM, Arnd Bergmann wrote:quoted
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig index 9cf394c66939..c298efe93f97 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig +++ b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig@@ -154,6 +154,7 @@ config MLX5_EN_IPSEC depends on MLX5_CORE_EN depends on XFRM_OFFLOAD depends on INET_ESP_OFFLOAD || INET6_ESP_OFFLOAD + depends on IPV6!=m || MLX5_CORE=mThanks for the fix. I received a report for this same error here: https://lore.kernel.org/oe-kbuild-all/202512261850.P5Jp5BSz-lkp@intel.com/ (local) We were about to send a fix ourselves, it is to simply add: depends on IPV6 || !IPV6 Is there a specific reason to prefer "depends on IPV6!=m || MLX5_CORE=m"? To me, the IPV6 || !IPV6 syntax seems a bit cleaner.MLX5_EN_IPSEC needs the dependency, but this is a 'bool' symbols. The "IPV6 || !IPV6" syntax only works on tristate symbols, so you'd have to put it into CONFIG_MLX5_CORE itself, but MLX5_CORE does not actually have the IPV6 dependency unless MLX5_EN_IPSEC is enabled.
Right, I meant moving the dependency to CONFIG_MLX5_CORE. Your patch restricts only MLX5_EN_IPSEC, which causes the link error, even if it silently disables IPsec in that specific config. Acked-by: Jianbo Liu <redacted>
Arnd