Re: [PATCH net-next 3/3] net: phy: dp83869: Support 1000Base-X SFP
From: Romain Gantois <romain.gantois@bootlin.com>
Date: 2025-11-04 09:10:48
Also in:
lkml
On Tuesday, 4 November 2025 10:01:36 CET Russell King (Oracle) wrote:
On Tue, Nov 04, 2025 at 09:50:36AM +0100, Romain Gantois wrote:quoted
+static void dp83869_module_remove(void *upstream) +{ + struct phy_device *phydev = upstream; + + phydev_info(phydev, "SFP module removed\n"); + + /* Set speed and duplex to unknown to avoid downshifting warning. */ + phydev->speed = SPEED_UNKNOWN; + phydev->duplex = DUPLEX_UNKNOWN;Should this be done by core phylib code?
I guess that enough PHY drivers do this by hand that a new phylib helper could be warranted. Maybe something like phy_clear_aneg_results(), which would set speed, duplex, pause and asym_pause to default values. Thanks, -- Romain Gantois, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Attachments
- signature.asc [application/pgp-signature] 833 bytes