Re: [PATCH net-next 1/3] net: phy: dp83869: Restart PHY when configuring mode

Hi Russell,

On Tuesday, 4 November 2025 09:57:59 CET Russell King (Oracle) wrote:

On Tue, Nov 04, 2025 at 09:50:34AM +0100, Romain Gantois wrote:

quoted

The DP83869 PHY requires a software restart when the OP_MODE is changed.

...

quoted

@@ -797,6 +797,10 @@ static int dp83869_configure_mode(struct phy_device

*phydev,> 
 		return -EINVAL;
 	
 	}

+	ret = phy_write(phydev, DP83869_CTRL, DP83869_SW_RESTART);

So if dp83869_configure_fiber() returns an error, that doesn't matter?
(This overwrites its error.)

That's a blunder on my part, thanks for pointing it out.

-- 
Romain Gantois, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com