Re: [PATCH net-next 1/3] net: phy: dp83869: Restart PHY when configuring mode
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
Date: 2025-11-04 08:58:09
Also in:
lkml
On Tue, Nov 04, 2025 at 09:50:34AM +0100, Romain Gantois wrote:
quoted hunk ↗ jump to hunk
The DP83869 PHY requires a software restart when the OP_MODE is changed. Add this restart in dp83869_configure_mode(). Signed-off-by: Romain Gantois <romain.gantois@bootlin.com> --- drivers/net/phy/dp83869.c | 4 ++++ 1 file changed, 4 insertions(+)diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c index 1f381d7b13ff..fecacaa83b04 100644 --- a/drivers/net/phy/dp83869.c +++ b/drivers/net/phy/dp83869.c@@ -797,6 +797,10 @@ static int dp83869_configure_mode(struct phy_device *phydev, return -EINVAL; } + ret = phy_write(phydev, DP83869_CTRL, DP83869_SW_RESTART);
So if dp83869_configure_fiber() returns an error, that doesn't matter? (This overwrites its error.) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!