Thread (30 messages) 30 messages, 4 authors, 2025-11-07

回覆: [PATCH net-next v3 3/4] ARM: dts: aspeed: ast2600-evb: Configure RGMII delay for MAC

From: Jacky Chou <jacky_chou@aspeedtech.com>
Date: 2025-11-04 04:54:51
Also in: linux-arm-kernel, linux-aspeed, linux-devicetree, lkml

Hi Andrew,
quoted
diff --git a/arch/arm/boot/dts/aspeed/aspeed-ast2600-evb.dts
b/arch/arm/boot/dts/aspeed/aspeed-ast2600-evb.dts
index de83c0eb1d6e..a65568e637bd 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-ast2600-evb.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-ast2600-evb.dts
@@ -121,44 +121,64 @@ ethphy3: ethernet-phy@0 {  };

 &mac0 {
+	compatible = "aspeed,ast2600-mac01", "aspeed,ast2600-mac",
+"faraday,ftgmac100";
Is it really compatible to aspeed,ast2600-mac? If a driver binds to that, not
aspeed,ast2600-mac01, doesn't that imply the bootloader delays are still in use,
so phy-mode will be wrong?

I think you should only list aspeed,ast2600-mac01. If somebody uses this DT
blob on an old kernel, then you won't get an ethernet interface, rather than a
not working ethernet interface, which is probably preferable.
Thanks for pointing that out.
Agreed. I'll update the patch to only use "aspeed,ast2600-mac01" as the compatible 
String like below, so that only the new driver version binds.
I'll also update the dt-binding yaml.

&mac0 {
	compatible = "aspeed,ast2600-mac01", "faraday,ftgmac100";
	...
};

Thanks,
Jacky
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help