Re: [PATCH net-next v3 1/4] dt-bindings: net: ftgmac100: Add delay properties for AST2600
From: Andrew Lunn <andrew@lunn.ch>
Date: 2025-11-04 04:08:13
Also in:
linux-arm-kernel, linux-aspeed, linux-devicetree, lkml
On Mon, Nov 03, 2025 at 03:39:16PM +0800, Jacky Chou wrote:
quoted hunk ↗ jump to hunk
Create the new compatibles to identify AST2600 MAC0/1 and MAC3/4. Add conditional schema constraints for Aspeed AST2600 MAC controllers: - For "aspeed,ast2600-mac01", require rx/tx-internal-delay-ps properties with 45ps step. - For "aspeed,ast2600-mac23", require rx/tx-internal-delay-ps properties with 250ps step. - Both require the "scu" property. Other compatible values remain unrestricted. Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com> --- .../devicetree/bindings/net/faraday,ftgmac100.yaml | 50 ++++++++++++++++++++++ 1 file changed, 50 insertions(+)diff --git a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml index d14410018bcf..de646e7e3bca 100644 --- a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml +++ b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml@@ -19,6 +19,12 @@ properties: - aspeed,ast2500-mac - aspeed,ast2600-mac
I don't know if it is possible, but it would be good to mark aspeed,ast2600-mac as deprecated. I also think some comments would be good, explaining how aspeed,ast2600-mac01 and aspeed,ast2600-mac23 differ from aspeed,ast2600-mac, and why you should use them. Andrew