Re: [PATCH net-next v3 3/4] ARM: dts: aspeed: ast2600-evb: Configure RGMII delay for MAC
From: Andrew Lunn <andrew@lunn.ch>
Date: 2025-11-04 04:01:13
Also in:
linux-arm-kernel, linux-aspeed, linux-devicetree, lkml
On Mon, Nov 03, 2025 at 03:39:18PM +0800, Jacky Chou wrote:
quoted hunk ↗ jump to hunk
This change sets the rx-internal-delay-ps and tx-internal-delay-ps properties to control the RGMII signal delay. The phy-mode for MAC0–MAC3 is updated to "rgmii-id" to enable TX/RX internal delay on the PHY and disable the corresponding delay on the MAC. Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com> --- arch/arm/boot/dts/aspeed/aspeed-ast2600-evb.dts | 28 +++++++++++++++++++++---- 1 file changed, 24 insertions(+), 4 deletions(-)diff --git a/arch/arm/boot/dts/aspeed/aspeed-ast2600-evb.dts b/arch/arm/boot/dts/aspeed/aspeed-ast2600-evb.dts index de83c0eb1d6e..a65568e637bd 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-ast2600-evb.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-ast2600-evb.dts@@ -121,44 +121,64 @@ ethphy3: ethernet-phy@0 { }; &mac0 { + compatible = "aspeed,ast2600-mac01", "aspeed,ast2600-mac", "faraday,ftgmac100";
Is it really compatible to aspeed,ast2600-mac? If a driver binds to that, not aspeed,ast2600-mac01, doesn't that imply the bootloader delays are still in use, so phy-mode will be wrong? I think you should only list aspeed,ast2600-mac01. If somebody uses this DT blob on an old kernel, then you won't get an ethernet interface, rather than a not working ethernet interface, which is probably preferable. Andrew