On 10.09.2025 10:28:08, Davide Caratti wrote:

hi,

On Wed, Sep 10, 2025 at 09:37:59AM +0200, Davide Caratti wrote:

quoted

quoted

...
# 4.13 [+0.00] # Exception| lib.py.utils.CmdExitFailure: Command failed:
        ['ip', '-netns', 'rhsbrszn', 'link', 'add', 'foo', 'type', 'vxcan']
# 4.14 [+0.00] # Exception| STDERR: b'Error: Unknown device type.\n'

quoted

Best regards, Ilya Maximets.

thanks for spotting this, I was testing the patch with:

 # vng --kconfig
 # yes | make kselftest-merge
 # grep ^CONFIG_CAN .config

Then it's probably safer to drop the first hunk - or restore to v1

https://lore.kernel.org/linux-can/fdab0848a377969142f5ff9aea79c4e357a72474.1755276597.git.dcaratti@redhat.com/ (local)

And I see that the build [1] is doing:

  CLEAN   scripts
  CLEAN   include/config include/generated arch/x86/include/generated .config .config.old .version Module.symvers

quoted

TREE CMD: vng -v -b -f tools/testing/selftests/net/config -f tools/testing/selftests/net/af_unix/config

  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/kconfig/conf.o

[1] https://netdev-3.bots.linux.dev/vmksft-net/results/291401/build/stdout 

while the enablement of CONFIG_CAN_VCAN is still necessary, the contents of selftests/net/config need to be preserved.
@Jakub,  @Marc, we can drop this patch from the series and I will respin to linux-can ? or you can adjust things in other ways?

You can send me a new or an incremental patch (which I'll squash into
the original one). Then I'll send a new PR.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |