On Tue, Sep 09, 2025 at 09:32:49PM +0200, Ilya Maximets wrote:

On 9/9/25 3:34 PM, Marc Kleine-Budde wrote:

quoted

From: Davide Caratti <redacted>

diff --git a/tools/testing/selftests/net/can/config b/tools/testing/selftests/net/can/config
new file mode 100644
index 000000000000..3326cba75799
--- /dev/null
+++ b/tools/testing/selftests/net/can/config

@@ -0,0 +1,4 @@
+CONFIG_CAN=m
+CONFIG_CAN_DEV=m
+CONFIG_CAN_VCAN=m
+CONFIG_CAN_VXCAN=m

diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config
index c24417d0047b..18bec89c77b9 100644
--- a/tools/testing/selftests/net/config
+++ b/tools/testing/selftests/net/config

@@ -120,9 +120,6 @@ CONFIG_XFRM_USER=m
 CONFIG_IP_NF_MATCH_RPFILTER=m
 CONFIG_IP6_NF_MATCH_RPFILTER=m
 CONFIG_IPVLAN=m
-CONFIG_CAN=m
-CONFIG_CAN_DEV=m
-CONFIG_CAN_VXCAN=m

Not an expert in the CI infra, but the link_netns test clearly
still needs these configs enabled in the common config file:

https://netdev-3.bots.linux.dev/vmksft-net/results/290682/56-link-netns-py/stdout

# selftests: net: link_netns.py
# 0.12 [+0.12] TAP version 13
# 0.12 [+0.00] 1..3
# 1.44 [+1.32] ok 1 link_netns.test_event
# 3.99 [+2.56] ok 2 link_netns.test_link_net
...
# 4.13 [+0.00] # Exception| lib.py.utils.CmdExitFailure: Command failed:
        ['ip', '-netns', 'rhsbrszn', 'link', 'add', 'foo', 'type', 'vxcan']
# 4.14 [+0.00] # Exception| STDERR: b'Error: Unknown device type.\n'

Best regards, Ilya Maximets.

thanks for spotting this, I was testing the patch with:

 # vng --kconfig
 # yes | make kselftest-merge
 # grep ^CONFIG_CAN .config

Then it's probably safer to drop the first hunk - or restore to v1

https://lore.kernel.org/linux-can/fdab0848a377969142f5ff9aea79c4e357a72474.1755276597.git.dcaratti@redhat.com/ (local)
-- 
davide