Re: [PATCH net 2/7] selftests: can: enable CONFIG_CAN_VCAN as a module
From: Ilya Maximets <i.maximets@ovn.org>
Date: 2025-09-09 19:32:53
Also in:
linux-can
On 9/9/25 3:34 PM, Marc Kleine-Budde wrote:
quoted hunk ↗ jump to hunk
From: Davide Caratti <redacted> A proper kernel configuration for running kselftest can be obtained with: $ yes | make kselftest-merge Build of 'vcan' driver is currently missing, while the other required knobs are already there because of net/link_netns.py [1]. Add a config file in selftests/net/can to store the minimum set of kconfig needed for CAN selftests. While at it, move existing CAN-related knobs from selftests/net to selftests/net/can. [1] https://patch.msgid.link/20250219125039.18024-14-shaw.leon@gmail.com Fixes: 77442ffa83e8 ("selftests: can: Import tst-filter from can-tests") Reviewed-by: Vincent Mailhol <mailhol@kernel.org> Signed-off-by: Davide Caratti <redacted> Link: https://patch.msgid.link/f1b942b5c85dda5de8ff243af158d8ba6432b59f.1756813350.git.dcaratti@redhat.com Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> --- tools/testing/selftests/net/can/config | 4 ++++ tools/testing/selftests/net/config | 3 --- 2 files changed, 4 insertions(+), 3 deletions(-) create mode 100644 tools/testing/selftests/net/can/configdiff --git a/tools/testing/selftests/net/can/config b/tools/testing/selftests/net/can/config new file mode 100644 index 000000000000..3326cba75799 --- /dev/null +++ b/tools/testing/selftests/net/can/config@@ -0,0 +1,4 @@ +CONFIG_CAN=m +CONFIG_CAN_DEV=m +CONFIG_CAN_VCAN=m +CONFIG_CAN_VXCAN=mdiff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config index c24417d0047b..18bec89c77b9 100644 --- a/tools/testing/selftests/net/config +++ b/tools/testing/selftests/net/config@@ -120,9 +120,6 @@ CONFIG_XFRM_USER=m CONFIG_IP_NF_MATCH_RPFILTER=m CONFIG_IP6_NF_MATCH_RPFILTER=m CONFIG_IPVLAN=m -CONFIG_CAN=m -CONFIG_CAN_DEV=m -CONFIG_CAN_VXCAN=m
Not an expert in the CI infra, but the link_netns test clearly still needs these configs enabled in the common config file: https://netdev-3.bots.linux.dev/vmksft-net/results/290682/56-link-netns-py/stdout # selftests: net: link_netns.py # 0.12 [+0.12] TAP version 13 # 0.12 [+0.00] 1..3 # 1.44 [+1.32] ok 1 link_netns.test_event # 3.99 [+2.56] ok 2 link_netns.test_link_net ... # 4.13 [+0.00] # Exception| lib.py.utils.CmdExitFailure: Command failed: ['ip', '-netns', 'rhsbrszn', 'link', 'add', 'foo', 'type', 'vxcan'] # 4.14 [+0.00] # Exception| STDERR: b'Error: Unknown device type.\n' Best regards, Ilya Maximets.