Thread (88 messages) 88 messages, 6 authors, 2025-10-07

Re: [PATCH v18 01/20] cxl: Add type2 device basic support

From: Jonathan Cameron <jonathan.cameron@huawei.com>
Date: 2025-09-30 14:43:47
Also in: linux-cxl

On Mon, 29 Sep 2025 11:21:33 +0100
Alejandro Lucero Palau [off-list ref] wrote:
On 9/23/25 12:21, Alejandro Lucero Palau wrote:
quoted
On 9/18/25 11:55, Jonathan Cameron wrote:  
quoted
On Thu, 18 Sep 2025 10:17:27 +0100
alejandro.lucero-palau@amd.com wrote:
 
quoted
From: Alejandro Lucero <redacted>

Differentiate CXL memory expanders (type 3) from CXL device 
accelerators
(type 2) with a new function for initializing cxl_dev_state and a macro
for helping accel drivers to embed cxl_dev_state inside a private
struct.

Move structs to include/cxl as the size of the accel driver private
struct embedding cxl_dev_state needs to know the size of this struct.

Use same new initialization with the type3 pci driver.

Signed-off-by: Alejandro Lucero <redacted>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Alison Schofield <alison.schofield@intel.com>  
 
quoted
diff --git a/Documentation/driver-api/cxl/theory-of-operation.rst 
b/Documentation/driver-api/cxl/theory-of-operation.rst
index 257f513e320c..ab8ebe7722a9 100644
--- a/Documentation/driver-api/cxl/theory-of-operation.rst
+++ b/Documentation/driver-api/cxl/theory-of-operation.rst
@@ -347,6 +347,9 @@ CXL Core
  .. kernel-doc:: drivers/cxl/cxl.h
     :internal:
  +.. kernel-doc:: include/cxl/cxl.h
+   :internal:
+  
Smells like a merge conflict issue given same entry is already there.
 
Yes, I'll fix it.


Thanks
 
Hi Jonathan,


When double-checking for v19, I am not sure what you meant here. It 
seems my answer was in "automatic mode" since there is no duplicate 
entry at all.


Note there is one line for another file with same name but different 
path. We discussed the file name for public cxl API for type2 drivers 
time ago, so I think this should not be a problem.
Indeed. Misread on my part.
quoted
 
quoted
quoted
  .. kernel-doc:: drivers/cxl/acpi.c
     :identifiers: add_cxl_resources  
 
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help