Re: [PATCH v18 07/20] sfc: create type2 cxl memdev
From: Dave Jiang <dave.jiang@intel.com>
Date: 2025-09-19 15:59:50
Also in:
linux-cxl
On 9/18/25 2:17 AM, alejandro.lucero-palau@amd.com wrote:
From: Alejandro Lucero <redacted> Use cxl API for creating a cxl memory device using the type2 cxl_dev_state struct. Signed-off-by: Alejandro Lucero <redacted> Reviewed-by: Martin Habets <redacted> Reviewed-by: Fan Ni <redacted> Acked-by: Edward Cree <ecree.xilinx@gmail.com> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com> with a nit below.
quoted hunk ↗ jump to hunk
--- drivers/net/ethernet/sfc/efx_cxl.c | 6 ++++++ 1 file changed, 6 insertions(+)diff --git a/drivers/net/ethernet/sfc/efx_cxl.c b/drivers/net/ethernet/sfc/efx_cxl.c index 651d26aa68dc..177c60b269d6 100644 --- a/drivers/net/ethernet/sfc/efx_cxl.c +++ b/drivers/net/ethernet/sfc/efx_cxl.c@@ -82,6 +82,12 @@ int efx_cxl_init(struct efx_probe_data *probe_data) return dev_err_probe(&pci_dev->dev, -ENODEV, "dpa capacity setup failed\n"); + cxl->cxlmd = devm_cxl_add_memdev(&pci_dev->dev, &cxl->cxlds, NULL); + if (IS_ERR(cxl->cxlmd)) { + pci_err(pci_dev, "CXL accel memdev creation failed");
As Jonathan mentioned. Maybe dev_err() to keep it consistent.
+ return PTR_ERR(cxl->cxlmd); + } + probe_data->cxl = cxl; return 0;