Thread (31 messages) 31 messages, 6 authors, 2025-08-29

Re: [PATCH net-next v2 5/9] xsk: add xsk_alloc_batch_skb() to build skbs in batch

From: Alexander Lobakin <aleksander.lobakin@intel.com>
Date: 2025-08-27 14:33:08
Also in: bpf

From: Jason Xing <redacted>
Date: Mon, 25 Aug 2025 21:53:38 +0800
From: Jason Xing <kernelxing@tencent.com>

Support allocating and building skbs in batch.
[...]
+	base_len = max(NET_SKB_PAD, L1_CACHE_ALIGN(dev->needed_headroom));
+	if (!(dev->priv_flags & IFF_TX_SKB_NO_LINEAR))
+		base_len += dev->needed_tailroom;
+
+	if (xs->skb_count >= nb_pkts)
+		goto build;
+
+	if (xs->skb) {
+		i = 1;
+		xs->skb_count++;
+	}
+
+	xs->skb_count += kmem_cache_alloc_bulk(net_hotdata.skbuff_cache,
+					       gfp_mask, nb_pkts - xs->skb_count,
+					       (void **)&skbs[xs->skb_count]);
Have you tried napi_skb_cache_get_bulk()? Depending on the workload, it
may give better perf numbers.
+	if (xs->skb_count < nb_pkts)
+		nb_pkts = xs->skb_count;
Thanks,
Olek
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help