Re: [PATCH net-next v2 2/9] xsk: add descs parameter in xskq_cons_read_desc_batch()

On Tue, Aug 26, 2025 at 5:19 AM Maciej Fijalkowski
[off-list ref] wrote:

On Mon, Aug 25, 2025 at 09:53:35PM +0800, Jason Xing wrote:

quoted

From: Jason Xing <kernelxing@tencent.com>

Add a new parameter to let generic xmit call this interface in the
subsequent patches.

Prior to this patch, pool->tx_descs in xskq_cons_read_desc_batch() is
only used to store a small number of descs in zerocopy mode. Later
another similar cache named xs->desc_batch will be used in copy mode.
So adjust the parameter for copy mode.

Explain why you couldn't reuse tx_descs as-is. Pool can not work both in
copy and zero-copy modes at the same time so I don't see the reason why
you couldn't reuse this for your needs?

Oh, right, spot on. I can reuse them instead of creating similar
wheels. Let me try this way.

Thanks,
Jason