Re: [PATCH v1 07/14] dt-bindings: display: mediatek,ufoe: Add mediatek,gce-client-reg property
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-08-21 06:50:08
Also in:
dri-devel, linux-arm-kernel, linux-clk, linux-devicetree, linux-gpio, linux-input, linux-media, linux-mediatek, linux-sound, lkml
On Wed, Aug 20, 2025 at 02:12:55PM -0300, Ariel D'Alessandro wrote:
Current, the DT bindings for Mediatek UFOe (Unified Frame Optimization engine) is missing the mediatek,gce-client-reg property. Add it and
Why is it missing? If the binding is complete, it cannot be missing...
quoted hunk ↗ jump to hunk
update the example as well. Signed-off-by: Ariel D'Alessandro <redacted> --- .../bindings/display/mediatek/mediatek,ufoe.yaml | 11 +++++++++++ 1 file changed, 11 insertions(+)diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ufoe.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ufoe.yaml index 61a5e22effbf2..ecb4c0359fec3 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ufoe.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ufoe.yaml@@ -64,6 +64,14 @@ properties: - port@0 - port@1 + mediatek,gce-client-reg: + description: The register of client driver can be configured by gce with + 4 arguments defined in this property, such as phandle of gce, subsys id, + register offset and size. Each GCE subsys id is mapping to a client
Don't explain what DT syntax is. We all know, so that's completely redundant description. Explain the purpose. Explain Arguments with sechema - items. Best regards, Krzysztof