Le 06/08/2025 à 10:14, Abhijit Gangurde a écrit :

On 8/2/25 02:45, Christophe JAILLET wrote:

quoted

Le 23/07/2025 à 19:31, Abhijit Gangurde a écrit :

quoted

To support RDMA capable ethernet device, create an auxiliary device in
the ionic Ethernet driver. The RDMA device is modeled as an auxiliary
device to the Ethernet device.

...

quoted

+static DEFINE_IDA(aux_ida);
+
+static void ionic_auxbus_release(struct device *dev)
+{
+    struct ionic_aux_dev *ionic_adev;
+
+    ionic_adev = container_of(dev, struct ionic_aux_dev, adev.dev);
+    kfree(ionic_adev);
+}
+
+int ionic_auxbus_register(struct ionic_lif *lif)

The 2 places that uses thus function don't check its error code.

For the eth driver, RDMA functionality is optional hence return code was 
missed. Although devlink parameter to control this is not included in 
this series, where it needs return value from this function. Till that 
point, I'll make it return void.

Don't bother with it.
If it is planned to be used later, I think it is fine to leave it as-is. 
This will save you some work.

Just ignore my comment.

CJ