On 7/23/25 23:41, Shannon Nelson wrote:

On 7/23/25 10:31 AM, Abhijit Gangurde wrote:

quoted

To support RDMA capable ethernet device, create an auxiliary device in
the ionic Ethernet driver. The RDMA device is modeled as an auxiliary
device to the Ethernet device.

Reviewed-by: Shannon Nelson <redacted>
Signed-off-by: Abhijit Gangurde <abhijit.gangurde@amd.com>
---
  drivers/net/ethernet/pensando/Kconfig         |  1 +
  drivers/net/ethernet/pensando/ionic/Makefile  |  2 +-
  .../net/ethernet/pensando/ionic/ionic_api.h   | 21 ++++
  .../net/ethernet/pensando/ionic/ionic_aux.c   | 95 +++++++++++++++++++
  .../net/ethernet/pensando/ionic/ionic_aux.h   | 10 ++
  .../ethernet/pensando/ionic/ionic_bus_pci.c   |  5 +
  .../net/ethernet/pensando/ionic/ionic_lif.c   |  7 ++
  .../net/ethernet/pensando/ionic/ionic_lif.h   |  3 +
  8 files changed, 143 insertions(+), 1 deletion(-)
  create mode 100644 drivers/net/ethernet/pensando/ionic/ionic_api.h
  create mode 100644 drivers/net/ethernet/pensando/ionic/ionic_aux.c
  create mode 100644 drivers/net/ethernet/pensando/ionic/ionic_aux.h

Hi Abhijit,

It occurred to me that there should be some discussion added into the 
ionic.rst file about this new auxiliary_device support.  You might 
look in the amd/pds_core.rst and mellanox/mlx5/switchdev.rst files for 
similar examples.  This perhaps isn't a blocker for this patchset, but 
should be planned soon, or added if you do another rev for other reasons.

(In a similar vein, the pds_core.rst should be updated for the new 
pds_core.fwctl auxiliary_device, but that's a different problem)

sln

Thanks Shannon. I will mention the rdma support via auxiliary device in 
the ionic.rst in next spin.

Abhijit